Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mono] Add initial arm64 hardware intrinsics support for mini JIT #82420

Merged
merged 15 commits into from
Mar 6, 2023
Merged

[Mono] Add initial arm64 hardware intrinsics support for mini JIT #82420

merged 15 commits into from
Mar 6, 2023

Conversation

fanyang-mono
Copy link
Member

@fanyang-mono fanyang-mono commented Feb 21, 2023 •
edited
Loading

The following has been added to mini JIT on arm64:

  • Enabled SIMD support for Vector128.
  • Emitted hardware intrinsics for add.
  • Fixed alignment for SIMD types on arm64.
  • Emitted arm64 intrinsics for various basic operations. They are OP_STOREX_MEMBASE, OP_LOADX_MEMBASE, OP_XZERO, OP_XCONST and OP_XMOVE.

Contributes to #80566

@ghost ghost assigned fanyang-mono Feb 21, 2023
fanyang-mono
fanyang-mono commented Feb 21, 2023
View reviewed changes
src/mono/mono/mini/simd-intrinsics.c Outdated
Comment on lines 1200 to 1203
// #ifdef TARGET_ARM64
// if (!(cfg->compile_aot && cfg->full_aot && !cfg->interp))
// return NULL;
// #endif
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Temporary commented these lines out for testing on CI. Need to uncomment before merging.

@vargaz
Copy link
Contributor

vargaz commented Feb 21, 2023

The ios-arm64 failures look relevant:
/tmp/helix/working/B18009D0/p/build/apple/AppleApp.targets(110,5): error : * Assertion at /Users/runner/work/1/s/src/mono/mono/mini/../../mono/arch/arm64/arm64-codegen.h:244, condition `arm_is_pimm12_scaled (pimm, size)' not met [/private/tmp/helix/working/B18009D0/w/9CB0086D/e/publish/ProxyProjectForAOTOnHelix.proj]

@build-analysis build-analysis bot mentioned this pull request Feb 21, 2023
Closed
jandupej
jandupej approved these changes Feb 21, 2023
View reviewed changes
src/mono/mono/mini/mini-arm64.c Outdated Show resolved Hide resolved
vargaz
vargaz reviewed Feb 22, 2023
View reviewed changes
src/mono/mono/mini/mini.c Outdated Show resolved Hide resolved
@build-analysis build-analysis bot mentioned this pull request Feb 22, 2023
Closed
@fanyang-mono fanyang-mono reopened this Feb 22, 2023
@runfoapp runfoapp bot mentioned this pull request Mar 1, 2023
Closed
This was referenced Mar 1, 2023
Open
Closed
@jandupej
Copy link
Member

jandupej commented Mar 3, 2023

Could not reproduce the RegularExpressions failure on macos,arm64; anyway it seems unrelated. Other failures also seem unrelated.

@fanyang-mono fanyang-mono reopened this Mar 3, 2023
@build-analysis build-analysis bot mentioned this pull request Mar 3, 2023
Closed
@runfoapp runfoapp bot mentioned this pull request Mar 6, 2023
Closed
@fanyang-mono
Copy link
Member Author

Failures on runtime (Build browser-wasm linux Release WasmBuildTests) are not related to this PR.

@fanyang-mono
Copy link
Member Author

wasm failures on CI are not related to this PR.

@fanyang-mono fanyang-mono merged commit d74dde7 into dotnet:main Mar 6, 2023
@kotlarmilos kotlarmilos mentioned this pull request Mar 8, 2023
Closed
@lewing lewing mentioned this pull request Mar 8, 2023
Closed
@fanyang-mono
Copy link
Member Author

fanyang-mono commented Mar 8, 2023 •
edited
Loading

Micro benchmarks improvement due of this PR:

@kotlarmilos kotlarmilos mentioned this pull request Mar 17, 2023
Closed
@kotlarmilos kotlarmilos mentioned this pull request Apr 4, 2023
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Apr 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vargaz vargaz vargaz approved these changes

@tannergooding tannergooding tannergooding left review comments

@jandupej jandupej jandupej approved these changes

@lambdageek lambdageek Awaiting requested review from lambdageek lambdageek is a code owner

@SamMonoRT SamMonoRT Awaiting requested review from SamMonoRT

Assignees

@fanyang-mono fanyang-mono

Labels
area-Codegen-Intrinsics-mono
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fanyang-mono @vargaz @jandupej @tannergooding